On Mon, Dec 12, 2022 at 02:27:46PM +0100, Oliver Neukum wrote:
On 12.12.22 14:14, Johan Hovold wrote:
On Mon, Dec 12, 2022 at 12:13:54PM +0100, Oliver Neukum wrote:
And in this case there was also no kernel doc for usb_get_intfdata()
which is equally self documenting. Why add redundant docs for only one
of these functions?
Because knowing that one of them exists makes the other much more
obvious.
I doubt anyone finds out about this function by reading generated kernel
documentation. You look at a driver, grep the function and look at the
single-line implementation.
But it was never perfectly good. It claims that a driver "should" use it,
when it may not need to (think simple driver using devres) and talks
about driver core resetting the pointer which is irrelevant.