Re: [PATCH] i40e (gcc13): synchronize allocate/free functions return type & values

From: Jiri Slaby
Date: Mon Dec 12 2022 - 06:56:04 EST


On 04. 11. 22, 21:28, Tony Nguyen wrote:


On 11/4/2022 11:47 AM, Jakub Kicinski wrote:
On Fri, 4 Nov 2022 11:33:07 -0700 Tony Nguyen wrote:
As Jiri mentioned, this is propagated up throughout the driver. We could
change this function to return int but all the callers would then need
to convert these errors to i40e_status to propagate. This doesn't really
gain much other than having this function return int. To adjust the
entire call chain is going to take more work. As this is resolving a
valid warning and returning what is currently expected, what are your
thoughts on taking this now to resolve the issue and our i40e team will
take the work on to convert the functions to use the standard errnos?

My thoughts on your OS abstraction layers should be pretty evident.
If anything I'd like to be more vigilant about less flagrant cases.

I don't think this is particularly difficult, let's patch it up
best we can without letting the "status" usage grow.

Ok thanks will do.

Just heads-up: have you managed to remove the abstraction yet?

thanks,
--
js
suse labs