Re: [PATCH v2] rtc: msc313: Fix function prototype mismatch in msc313_rtc_probe()
From: Daniel Palmer
Date: Fri Dec 09 2022 - 23:14:22 EST
Hi Kees,
On Sat, 3 Dec 2022 at 03:45, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> msc313_rtc_probe() was passing clk_disable_unprepare() directly, which
> did not have matching prototypes for devm_add_action_or_reset()'s
> callback argument. Refactor to use devm_clk_get_enabled() instead.
I didn't know devm_clk_get_enabled() existed. Learned something new. :)
Really nice that it fixes an issue and gets rid of a bunch of lines.
Anyhow, the change looks good to me, I build, boot and "does RTC still
work?" tested this so:
Reviewed-by: Daniel Palmer <daniel@xxxxxxxxx>
Tested-by: Daniel Palmer <daniel@xxxxxxxxx>
Cheers,
Daniel