Re: [PATCH] livepatch: Call klp_match_callback() in klp_find_callback() to avoid code duplication

From: Petr Mladek
Date: Fri Dec 09 2022 - 09:36:59 EST


On Fri 2022-12-09 19:29:56, Leizhen (ThunderTown) wrote:
>
>
> On 2022/12/9 17:12, Petr Mladek wrote:
> > On Wed 2022-12-07 11:23:04, Zhen Lei wrote:
> >> The implementation of function klp_match_callback() is identical to the
> >> partial implementation of function klp_find_callback(). So call function
> >> klp_match_callback() in function klp_find_callback() instead of the
> >> duplicated code.
> >>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> >
> > Thanks for cleaning this.
> >
> > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
>
> Oh, sorry, I realized that I had forgotten to add:
> Suggested-by: Petr Mladek <pmladek@xxxxxxxx>
>
> Hi Luis:
> Can you help me add it?

JFYI, I could live without it ;-)

Best Regards,
Petr