Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

[Kuogee Hsieh]

On 12/8/2022 3:33 PM, Dmitry Baryshkov wrote:
> On 09/12/2022 00:36, Kuogee Hsieh wrote:
> > Add both data-lanes and link-frequencies property into endpoint
> >
> > Changes in v7:
> > -- split yaml out of dtsi patch
> > -- link-frequencies from link rate to symbol rate
> > -- deprecation of old data-lanes property
> >
> > Changes in v8:
> > -- correct Bjorn mail address to kernel.org
> >
> > Changes in v10:
> > -- add menu item to data-lanes and link-frequecnis
> >
> > Changes in v11:
> > -- add endpoint property at port@1
> >
> > Signed-off-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>`
>
> Applying: dt-bindings: msm/dp: add data-lanes and link-frequencies 
> property
> .git/rebase-apply/patch:47: trailing whitespace.
>
> .git/rebase-apply/patch:51: trailing whitespace.
>
>
> Also the dt_binding_check fails with an error for this schema. And 
> after fixing the error in the schema I faced an example validation 
> error. Did you check that the schema is correct and that the example 
> validates against the schema?

yes, but i run "make dt_binding_check 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml" 
at mu v5.15 branch since

"make dt_binding_check" does not work at msm-next branch.

But I did not check trainiling whitespace this time.

> > ---
> >   .../bindings/display/msm/dp-controller.yaml        | 27 
> > ++++++++++++++++++++++
> >   1 file changed, 27 insertions(+)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml 
> > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > index f2515af..2a7fdef8 100644
> > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > @@ -81,6 +81,7 @@ properties:
> >       data-lanes:
> >       $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    deprecated: true
> >       minItems: 1
> >       maxItems: 4
> >       items:
> > @@ -96,6 +97,7 @@ properties:
> >       ports:
> >       $ref: /schemas/graph.yaml#/properties/ports
> > +
> >       properties:
> >         port@0:
> >           $ref: /schemas/graph.yaml#/properties/port
> > @@ -105,6 +107,29 @@ properties:
> >           $ref: /schemas/graph.yaml#/properties/port
> >           description: Output endpoint of the controller
> >   +        properties:
> > +          endpoint:
> > +            $ref: /schemas/media/video-interfaces.yaml#
> > +
> > +            properties:
> > +              remote-endpoint: true
>
> PLease add empty lines between the property definitions
>
> > +              data-lanes:
> > +                $ref: /schemas/types.yaml#/definitions/uint32-array
>
> This is already a part of video-interfaces, so you don't need $ref
>
> > +                minItems: 1
> > +                maxItems: 4
> > +                items:
> > +                  maximum: 3
>
> enum: [0, 1, 2, 3]
>
> > +              link-frequencies:
> > +                $ref: /schemas/types.yaml#/definitions/uint64-array
> > +                minItems: 1
> > +                maxItems: 4
> > +                items:
> > +                  maximum: 8100000000
>
> I think we can have enum here too.
>
> > +
> > +  required:
> > +    - port@0
> > +    - port@1
> > +
> >   required:
> >     - compatible
> >     - reg
> > @@ -193,6 +218,8 @@ examples:
> >                   reg = <1>;
> >                   endpoint {
> >                       remote-endpoint = <&typec>;
> > +                    data-lanes = <0 1>;
> > +                    link-frequencies = /bits/ 64 <1620000000 
> > 2700000000 5400000000 8100000000>;
> >                   };
> >               };
> >           };