Re: [PATCH v1 3/3] riscv: dts: starfive: Add mmc node
From: Linus Walleij
Date: Thu Dec 08 2022 - 16:15:24 EST
Hi William,
thanks for your patch!
On Wed, Dec 7, 2022 at 2:17 PM William Qiu <william.qiu@xxxxxxxxxxxxxxxx> wrote:
> + starfive,sys-syscon = <&sys_syscon 0x14 0x1a 0x7c000000>;
(...)
> + starfive,sys-syscon = <&sys_syscon 0x9c 0x1 0x3e>;
These are registster offsets and shifts. Don't define such stuff in your device
tree, use #defines in the code and just provide the phandle.
Yours,
Linus Walleij