Re: [PATCH v2 3/3] hwmon: (pmbus/core): Implement irq support

[Naresh Solanki]

Hi Guenter,

On 29-11-2022 08:59 pm, Guenter Roeck wrote:
> On 11/29/22 00:16, Naresh Solanki wrote:
> > Hi Guenter,
> >
> > On 29-11-2022 04:39 am, Guenter Roeck wrote:
> > > On 11/28/22 09:47, Naresh Solanki wrote:
> > > > From: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> > > >
> > > > Implement PMBUS irq handler to notify regulator events.
> > > >
> > > > Signed-off-by: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> > > > Signed-off-by: Naresh Solanki <Naresh.Solanki@xxxxxxxxxxxxx>
> > >
> > > As I am sure I have mentioned before, this needs to primarily handle
> > > sysfs notifications to hwmon status attributes and to generate kobject
> > > events. Regulator events are secondary / optional.
> >
> > Based on previous feedback, PMBus interrupt handler is made generic
> > Based on the use case I have in my machine, my application need to 
> > monitor regulator event as soon as they occur and hence the patch.
>
> I understand, but this isn't just about your specific use case. Your use 
> case is
> what triggers the change, and ensures that the code change is tested, 
> but the
> impact by far reaches beyond your specific use case and needs to address 
> other
> (much more common) use cases as well. Interrupt support is needed in the 
> pmbus
> code, but it needs to address the common use case first, and that is 
> reporting
> the status via sysfs notifications and kobject events.
Agree. I've done the implementation. Will submit the change as separate 
patch along with the series.
> Thanks,
> Guenter
Regards,
Naresh