Re: [PATCH 1/3] genirq: Simplify cond_unmask_eoi_irq()

From: Thomas Gleixner
Date: Wed Nov 30 2022 - 10:30:04 EST


On Wed, Nov 30 2022 at 15:48, Thomas Gleixner wrote:
> On Sat, Nov 26 2022 at 17:41, Samuel Holland wrote:
>> + (desc->istate & IRQS_ONESHOT) && !desc->threads_oneshot)
>> unmask_irq(desc);
>
> This breaks the mask logic of handle_fasteoi_mask_irq() for an interrupt
> which does not have IRQS_ONESHOT set.

Ignore this one. That handler is broken by design.