Re: [PATCH 2/2] dt-bindings: interconnect: Add SM6115 DT bindings

[Bhupesh Sharma]

Hi Krzysztof,

Thanks for your review.

On Wed, 30 Nov 2022 at 17:11, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 30/11/2022 11:38, Bhupesh Sharma wrote:
> > The Qualcomm SM6115 SoC has several bus fabrics that could be
> > controlled and tuned dynamically according to the bandwidth demand.
> >
> > Add the support for the same.
> >
> > Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> > ---
>
> Thank you for your patch. There is something to discuss/improve.
>
> We could create common properties for these bindings, but it's fine now.
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/qcom,rpmcc.h>
> > +
> > +    snoc: interconnect@1880000 {
> > +        compatible = "qcom,sm6115-snoc";
> > +        reg = <0x01880000 0x60200>;
> > +        #interconnect-cells = <1>;
> > +        clock-names = "bus", "bus_a";
> > +        clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> > +                 <&rpmcc RPM_SMD_SNOC_A_CLK>;
> > +
> > +        clk_virt: interconnect-clk {
> > +            compatible = "qcom,sm6115-clk-virt";
> > +            #interconnect-cells = <1>;
> > +            clock-names = "bus", "bus_a";
> > +            clocks = <&rpmcc RPM_SMD_QUP_CLK>,
> > +                     <&rpmcc RPM_SMD_QUP_A_CLK>;
> > +        };
> > +
> > +        mmnrt_virt: interconnect-mmnrt {
> > +            compatible = "qcom,sm6115-mmnrt-virt";
> > +            #interconnect-cells = <1>;
> > +            clock-names = "bus", "bus_a";
> > +            clocks = <&rpmcc RPM_SMD_MMNRT_CLK>,
> > +                     <&rpmcc RPM_SMD_MMNRT_A_CLK>;
> > +        };
> > +
> > +        mmrt_virt: interconnect-mmrt {
> > +            compatible = "qcom,sm6115-mmrt-virt";
> > +            #interconnect-cells = <1>;
> > +            clock-names = "bus", "bus_a";
> > +            clocks = <&rpmcc RPM_SMD_MMRT_CLK>,
> > +                     <&rpmcc RPM_SMD_MMRT_A_CLK>;
> > +        };
>
> Drop last two nodes - they are the same as first.
>
> > +    };
> > +
> > +    cnoc: interconnect@1900000 {
> > +        compatible = "qcom,sm6115-cnoc";
> > +        reg = <0x01900000 0x8200>;
> > +        #interconnect-cells = <1>;
> > +        clock-names = "bus", "bus_a";
> > +        clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
> > +                 <&rpmcc RPM_SMD_CNOC_A_CLK>;
> > +    };
> > +
> > +    bimc: interconnect@4480000 {
> > +        compatible = "qcom,sm6115-bimc";
> > +        reg = <0x04480000 0x80000>;
> > +        #interconnect-cells = <1>;
> > +        clock-names = "bus", "bus_a";
> > +        clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> > +                 <&rpmcc RPM_SMD_BIMC_A_CLK>;
> > +    };
>
> Drop these two as well, they do not bring anything new here.

Ack for both the suggestions. I will fix and send a v2 shortly.

Regards,
Bhupesh