Re: [PATCH v2 1/2] gpiolib: Provide to_gpio_device() helper

From: Bartosz Golaszewski
Date: Tue Nov 29 2022 - 08:52:24 EST


On Tue, Nov 29, 2022 at 2:46 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Nov 29, 2022 at 01:50:51PM +0100, Bartosz Golaszewski wrote:
> > On Mon, Nov 28, 2022 at 8:00 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> ...
>
> > > While at it, make sure it becomes no-op at compilation time.
>
> ^^^
>
> > > - int id;
> >
> > Sorry I didn't notice it before but why the churn? This is not needed
> > for container_of to work.
>
> > > + int id;
>
> I hope this explains and can be accepted.
>

Ah, alright makes sense. Applying.

Bart