Re: [PATCH V3 2/3] tracing/osnoise: Add preempt/irq disable options

From: Daniel Bristot de Oliveira
Date: Tue Nov 29 2022 - 03:27:54 EST


On 11/28/22 21:39, Steven Rostedt wrote:
> On Fri, 25 Nov 2022 22:20:23 +0100
> Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
>
>> @@ -1308,6 +1315,8 @@ static void notify_new_max_latency(u64 latency)
>> */
>> static int run_osnoise(void)
>> {
>> + bool preempt_disable = test_bit(OSN_PREEMPT_DISABLE, &osnoise_options);
>> + bool irq_disable = test_bit(OSN_IRQ_DISABLE, &osnoise_options);
> bool irq_disable = test_bit(OSN_IRQ_DISABLE, &osnoise_options);
> bool preempt_disable = IS_ENABLED(CONFIG_PREEMPT) &&
> !irq_disable && test_bit(OSN_PREEMPT_DISABLE, &osnoise_options);
>


Ooops, you are right. I will fix this, and the doc as well, in the v4.

Thanks
-- Daniel