Re: [PATCH v2 2/2] dt-bindings: i2c: add loongson i2c

From: Yinbo Zhu
Date: Tue Nov 29 2022 - 01:56:26 EST



在 2022/11/29 7:51, Yinbo Zhu 写道:

在 2022/11/28 22:11, Krzysztof Kozlowski 写道:
On 28/11/2022 14:00, Yinbo Zhu wrote:
Add the Loongson platform i2c binding with DT schema format using
json-schema.

Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
---
Change in v2:
        1. Removed the "#address-cells" and "#size-cells" in requied.
        2. Add the reviewed-by information.

  .../bindings/i2c/loongson,ls-i2c.yaml         | 47 +++++++++++++++++++
  MAINTAINERS                                   |  1 +
  2 files changed, 48 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml

diff --git a/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml b/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml
new file mode 100644
index 000000000000..0e4aee9146f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/loongson,ls-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Loongson I2C controller
+
+maintainers:
+  - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
+
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+  compatible:
+    enum:
+      - loongson,ls2k-i2c
+      - loongson,ls7a-i2c
Why do we have the same bindings twice, with different people and file
names?

https://lore.kernel.org/all/57339e73b6c0bfe446e19a7f55a48b7ca640b9ec.1669359515.git.zhoubinbin@xxxxxxxxxxx/

Best regards,
Krzysztof

Inthe previous internal discussion, I was assigned to go to upstream for i2c, but I

don't know why other people are also working on the patch. I will go to

internal communication.

Hi

please follow zhoubinbin's loongson i2c series patch.

I will not cover it.


Thanks,

Yinbo.