Re: [PATCH net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER

From: Jakub Kicinski
Date: Mon Nov 28 2022 - 21:15:26 EST


On Tue, 29 Nov 2022 11:01:51 +0900 Vincent Mailhol wrote:
> As discussed in [1], abbreviating the bootloader to "bl" might not be
> well understood. Instead, a bootloader technically being a firmware,
> name it "fw.bootloader".
>
> Add a new macro to devlink.h to formalize this new info attribute
> name.
>
> [1] https://lore.kernel.org/netdev/20221128142723.2f826d20@xxxxxxxxxx/
>
> Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>

It's okay for this patch to go via the can tree, FWIW.
It may cause an extra delay for you if you have to wait
for the define to propagate.

Either way you should document the meaning of the parameter,
however obvious it may seem:

Documentation/networking/devlink/devlink-info.rst