Re: [BUG] Add missing <linux/string.h> include for strcmp.

From: Sam James
Date: Mon Nov 28 2022 - 16:27:28 EST




> On 28 Nov 2022, at 21:25, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, 28 Nov 2022 18:15:55 +0100 "H. Nikolaus Schaller" <hns@xxxxxxxxxxxxx> wrote:
>
>> starting with v6.1-rc7 I can't build my tree any more:
>>
>> HOSTCC scripts/mod/modpost.o - due to target missing
>> In file included from include/linux/string.h:5,
>> from scripts/mod/../../include/linux/license.h:5,
>> from scripts/mod/modpost.c:24:
>> include/linux/compiler.h:246:10: fatal error: asm/rwonce.h: No such file or directory
>> 246 | #include <asm/rwonce.h>
>> | ^~~~~~~~~~~~~~
>> compilation terminated.
>>
>> Bisect did show your patch as the first bad one:
>>
>> commit 50c697215a8c "Add missing <linux/string.h> include for strcmp."
>>
>> Reverting it makes compile succeed.
>
> Thanks. I queued a reversion patch.

Thanks, I can't look into it properly right now so this is the best course of action. I'll test cross and the like then submit a fixed one in a few days.