Re: [PATCH/RFC 2/3] drm/simple-kms-helper: Add mode_fixup() to simple display pipe

[Maxime Ripard]

Hi,

On Fri, Nov 25, 2022 at 09:31:09PM +0100, Geert Uytterhoeven wrote:
> From: Thomas Zimmermann <tzimmermann@xxxxxxx>
> 
> The mode fix-up function for simple display helpers is equivalent to the
> regular pipeline's CRTC mode fix-up function. It's called to adjust the
> CRTC's display mode for the encoder. Add this function for DRM fbconv
> helpers.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

It's not clear to me why you'd need a mode_fixup in the first place.
Like said in the documentation you added, atomic_check is usually the
better option for the atomic modesetting drivers.

So, why is it needed?

Maxime

Attachment: signature.asc
Description: PGP signature