Re: [PATCH v6 02/10] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation

From: Krzysztof Kozlowski
Date: Sun Nov 27 2022 - 07:59:18 EST


On 25/11/2022 16:10, Alexandre Mergnat wrote:
> - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml
> - Add maintainer
> - Remove the .txt binding file

Conversion includes removal, so you can skip the last comment.

>
> Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +-
> .../bindings/rtc/mediatek,mt6397-rtc.yaml | 35 ++++++++++++++++++++++
> .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 -------------------
> 3 files changed, 36 insertions(+), 32 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> index 0088442efca1..79aaf21af8e9 100644
> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> @@ -33,7 +33,7 @@ Optional subnodes:
> - compatible: "mediatek,mt6331-rtc"
> - compatible: "mediatek,mt6358-rtc"
> - compatible: "mediatek,mt6397-rtc"
> - For details, see ../rtc/rtc-mt6397.txt
> + For details, see ../rtc/mediatek,mt6397-rtc.yaml
> - regulators
> Required properties:
> - compatible: "mediatek,mt6323-regulator"
> diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml
> new file mode 100644
> index 000000000000..97b09c81e548
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml
> @@ -0,0 +1,35 @@
> + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6397/MT6366/MT6358/MT6323 RTC
> +
> +maintainers:
> + - Tianping Fang <tianping.fang@xxxxxxxxxxxx>
> + - Alexandre Mergnat <amergnat@xxxxxxxxxxxx>
> +
> +description:
> + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works
> + as a type of multi-function device (MFD). The RTC can be configured and set up
> + with PMIC wrapper bus which is a common resource shared with the other
> + functions found on the same PMIC.
> +
> +allOf:
> + - $ref: rtc.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt6323-rtc
> + - mediatek,mt6358-rtc
> + - mediatek,mt6366-rtc
> + - mediatek,mt6397-rtc
> +
> + start-year: true
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> deleted file mode 100644
> index 7212076a8f1b..000000000000
> --- a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -Device-Tree bindings for MediaTek PMIC based RTC
> -
> -MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works
> -as a type of multi-function device (MFD). The RTC can be configured and set up
> -with PMIC wrapper bus which is a common resource shared with the other
> -functions found on the same PMIC.
> -
> -For MediaTek PMIC MFD bindings, see:
> -../mfd/mt6397.txt
> -
> -For MediaTek PMIC wrapper bus bindings, see:
> -../soc/mediatek/pwrap.txt
> -
> -Required properties:
> -- compatible: Should be one of follows
> - "mediatek,mt6323-rtc": for MT6323 PMIC
> - "mediatek,mt6358-rtc": for MT6358 PMIC
> - "mediatek,mt6366-rtc", "mediatek,mt6358-rtc": for MT6366 PMIC

That's not equivalent change and you did not mention any differences
from conversion.

Regardless of it, Rob suggested squashing it into MFD device schema and
I think his proposal is still valid - you have here only two properties...

Best regards,
Krzysztof