Re: [Freedreno] [PATCH v2 03/12] drm/msm/dpu: Refactor sc7280_pp location

[Abhinav Kumar]

On 11/15/2022 5:33 AM, Konrad Dybcio wrote:
> On 15/11/2022 14:30, Robert Foss wrote:
> > The sc7280_pp declaration is not located by the other _pp
> > declarations, but rather hidden around the _merge_3d
> > declarations. Let's fix this to avoid confusion.
> >
> > Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> This is already merged.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=1a5b5372e3b0a4cc65a0cbb724b1b0859f4ac63c 
>
>
> Konrad

Its part of linux-next but a PR hasnt been sent with it.

That being said, since this particular change has been taken separately, 
this series should now be rebased without this change and addressing 
some of the other comments given by konrad.

> >   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 14 +++++++-------
> >   1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c 
> > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > index 4dac90ee5b8a..8f2d634f7b6b 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > @@ -1294,6 +1294,13 @@ static const struct dpu_pingpong_cfg 
> > sm8150_pp[] = {
> >               -1),
> >   };
> > +static const struct dpu_pingpong_cfg sc7280_pp[] = {
> > +    PP_BLK("pingpong_0", PINGPONG_0, 0x59000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > +    PP_BLK("pingpong_1", PINGPONG_1, 0x6a000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > +    PP_BLK("pingpong_2", PINGPONG_2, 0x6b000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > +    PP_BLK("pingpong_3", PINGPONG_3, 0x6c000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > +};
> > +
> >   static struct dpu_pingpong_cfg qcm2290_pp[] = {
> >       PP_BLK("pingpong_0", PINGPONG_0, 0x70000, 0, sdm845_pp_sblk,
> >           DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8),
> > @@ -1352,13 +1359,6 @@ static const struct dpu_merge_3d_cfg 
> > sm8450_merge_3d[] = {
> >       MERGE_3D_BLK("merge_3d_3", MERGE_3D_3, 0x65f00),
> >   };
> > -static const struct dpu_pingpong_cfg sc7280_pp[] = {
> > -    PP_BLK("pingpong_0", PINGPONG_0, 0x59000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > -    PP_BLK("pingpong_1", PINGPONG_1, 0x6a000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > -    PP_BLK("pingpong_2", PINGPONG_2, 0x6b000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > -    PP_BLK("pingpong_3", PINGPONG_3, 0x6c000, 0, sc7280_pp_sblk, -1, 
> > -1),
> > -};
> > -
> >   /*************************************************************
> >    * DSC sub blocks config
> >    *************************************************************/