Re: [PATCH 092/606] iio: dac: ti-dac5571: Convert to i2c's .probe_new()

From: Laurent Pinchart
Date: Sat Nov 19 2022 - 12:42:44 EST


On Fri, Nov 18, 2022 at 11:37:06PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> .probe_new() doesn't get the i2c_device_id * parameter, so determine
> that explicitly in the probe function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/iio/dac/ti-dac5571.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index 3210e3098f9a..40191947fea3 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -306,9 +306,9 @@ static const struct iio_info dac5571_info = {
> .write_raw_get_fmt = dac5571_write_raw_get_fmt,
> };
>
> -static int dac5571_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int dac5571_probe(struct i2c_client *client)
> {
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> struct device *dev = &client->dev;
> const struct dac5571_spec *spec;
> struct dac5571_data *data;
> @@ -426,7 +426,7 @@ static struct i2c_driver dac5571_driver = {
> .name = "ti-dac5571",
> .of_match_table = dac5571_of_id,
> },
> - .probe = dac5571_probe,
> + .probe_new = dac5571_probe,
> .remove = dac5571_remove,
> .id_table = dac5571_id,
> };
> --
> 2.38.1
>

--
Regards,

Laurent Pinchart