Re: [PATCH] scsi: pm8001: Drop !task check in pm8001_abort_task()

From: Martin K. Petersen
Date: Mon Nov 07 2022 - 23:02:27 EST


On Wed, 26 Oct 2022 18:56:04 +0800, John Garry wrote:

> In commit 0b639decf651 ("scsi: pm8001: Modify task abort handling for SATA
> task"), code was introduced to dereference "task" pointer in
> pm8001_abort_task(). However there was a pre-existing later check for
> "!task", which spooked the kernel test robot.
>
> Function pm8001_abort_task() should never be passed NULL for "task"
> pointer, so remove that check. Also remove the "unlikely" hint, as this is
> not fastpath code.
>
> [...]

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: pm8001: Drop !task check in pm8001_abort_task()
https://git.kernel.org/mkp/scsi/c/4481bdc677c1

--
Martin K. Petersen Oracle Linux Engineering