Re: [PATCH v2] extcon: usbc-tusb320: Call the Type-C IRQ handler only if a port is registered

From: Marek Vasut
Date: Mon Nov 07 2022 - 13:02:31 EST


On 11/7/22 17:28, Heikki Krogerus wrote:
On Mon, Nov 07, 2022 at 06:33:17PM +0300, Yassine Oudjana wrote:
From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>

Commit bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
added an optional Type-C interface to the driver but missed to check
if it is in use when calling the IRQ handler. This causes an oops on
devices currently using the old extcon interface. Check if a Type-C
port is registered before calling the Type-C IRQ handler.

Fixes: bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
Reviewed-by: Marek Vasut <marex@xxxxxxx>

Looks good to me. FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

Likewise, looks good. You already have my RB. Thanks !