Re: [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()
From: Miquel Raynal
Date: Mon Nov 07 2022 - 11:28:56 EST
On Thu, 2022-10-27 at 13:10:27 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
>
> drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
> 380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
>
> Reported-by: noreply@xxxxxxxxxxxxxx
> Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel