Re: [RFC PATCH v3 3/3] drm: initialize accel framework

From: Jeffrey Hugo
Date: Mon Nov 07 2022 - 11:28:37 EST


On 11/6/2022 2:02 PM, Oded Gabbay wrote:

@@ -603,6 +626,14 @@ static int drm_dev_init(struct drm_device *dev,
/* no per-device feature limits by default */
dev->driver_features = ~0u;

+ if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL) &&
+ (drm_core_check_feature(dev, DRIVER_RENDER) ||
+ drm_core_check_feature(dev, DRIVER_MODESET))) {

Shouldn't the indentation for the 2nd and 3rd line be such that the start of the lines is aligned with the "(" on the first line?