Re: [PATCH v11 2/2] Documentation: Add document for UltraSoc SMB drivers

[Jonathan Cameron]

On Mon, 7 Nov 2022 21:06:24 +0800
Junhao He <hejunhao3@xxxxxxxxxx> wrote:

> From: Qi Liu <liuqi115@xxxxxxxxxx>
> 
> This patch bring in documentation for UltraSoc SMB drivers.
> It simply describes the device, sysfs interface and the
> firmware bindings.
> 
> Signed-off-by: Qi Liu <liuqi115@xxxxxxxxxx>
> Signed-off-by: Junhao He <hejunhao3@xxxxxxxxxx>
> ---
>  .../sysfs-bus-coresight-devices-ultra_smb     | 31 +++++++
>  .../trace/coresight/ultrasoc-smb.rst          | 80 +++++++++++++++++++
>  2 files changed, 111 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-ultra_smb
>  create mode 100644 Documentation/trace/coresight/ultrasoc-smb.rst
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-ultra_smb b/Documentation/ABI/testing/sysfs-bus-coresight-devices-ultra_smb
> new file mode 100644
> index 000000000000..7804aef4b40b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-ultra_smb
> @@ -0,0 +1,31 @@
> +What:		/sys/bus/coresight/devices/ultra_smb<N>/enable_sink
> +Date:		October 2022
> +KernelVersion:	6.1

Update to 6.2 as this will hopefully go in next merge window and it makes
life easier for the maintainer if they don't need to fix all these up.


> +Contact:	Junhao He <hejunhao3@xxxxxxxxxx>
> +Description:	(RW) Add/remove a SMB device from a trace path. There can be
> +		multiple sources for a single SMB device.

Rest looks good to me, (not an expert on this stuff though!)

Jonathan