Re: [PATCH] rtla: Fix exit status when returning from calls to usage()

From: John Kacur
Date: Mon Nov 07 2022 - 08:54:38 EST




On Fri, 4 Nov 2022, Daniel Bristot de Oliveira wrote:

> On 11/3/22 14:57, John Kacur wrote:
> > rtla_usage(), osnoise_usage() and timerlat_usage() all exit with an
> > error status
>
> missing .
?

>
> > However when these are called from help, they should exit with a
> > non-error status.
> >
> > Fix this by passing the exit status to the functions
>
> missing .
?

>
> > Note, although we remove the subsequent call to exit after calling
> > usage, we leave it in at the end of a function to supress the compiler
>
> suppress?
Of course, thanks for the spelling check!

>
> > warning "control reaches end of a non-void function"
>
> missing .
?

>
> Yep, that is a problem, and agree with the solution (I am already doing it
> in the rv cmd line).
cool

>
> -- Daniel
>