RE: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping

[Peng Fan]

> -----Original Message-----
> From: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> Sent: 2022年11月4日 23:28
> To: Peng Fan <peng.fan@xxxxxxx>
> Cc: Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>; andersson@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; linux-
> remoteproc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping
> 
> On Thu, Nov 03, 2022 at 06:11:46AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM
> > > mapping
> > >
> > > On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> > > wrote:
> > > >
> > > > From: Peng Fan <peng.fan@xxxxxxx>
> > > >
> > > > According to updated reference mannual, the M33 DRAM view of
> > > > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it.
> > > >
> > > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93")
> > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > > ---
> > > >  drivers/remoteproc/imx_rproc.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/remoteproc/imx_rproc.c
> > > > b/drivers/remoteproc/imx_rproc.c index 2c471e46f4ca..9fc978e0393c
> > > > 100644
> > > > --- a/drivers/remoteproc/imx_rproc.c
> > > > +++ b/drivers/remoteproc/imx_rproc.c
> > > > @@ -134,8 +134,8 @@ static const struct imx_rproc_att
> > > imx_rproc_att_imx93[] = {
> > > >         { 0x80000000, 0x80000000, 0x10000000, 0 },
> > > >         { 0x90000000, 0x80000000, 0x10000000, 0 },
> > > >
> > > > -       { 0xC0000000, 0xa0000000, 0x10000000, 0 },
> > > > -       { 0xD0000000, 0xa0000000, 0x10000000, 0 },
> > > > +       { 0xC0000000, 0xC0000000, 0x10000000, 0 },
> > > > +       { 0xD0000000, 0xC0000000, 0x10000000, 0 },
> > >
> > > But how did this work before?  Were some SoC released with the old
> > > mapping?
> 
> As it is regularly the case, you have not answered all my questions.

The DRAM mapping was not tested, I just wrote them down according
to the information I had.  In this patch, I just fix the mapping at address
0xC0000000, I not add 0xA0000000, I may also add it or use a separate
patch, which would you prefer?

The i.MX93 SoC is still in pre-production phase, and there is no public
Information for now.

Regards,
Peng.
> 
> > The current m33 firmware release with Linux SDK only has TCM version,
> > so I not have image to test the DDR mapping.
> >
> > Initially we got the information that M33 mapping of DRAM.
> > DRAM (offset 0 MB)	DRAM	80000000
> > DRAM (offset 256 MB)	DRAM	A0000000
> > DRAM (offset 512 MB)	DRAM	C0000000
> >
> > However the information is wrong after we check more, there is an
> > 256MB hole, 0MB [0x80000000, 0x8fffffff], 512MB [0xa0000000,
> > 0xafffffff], 1024MB [0xc0000000, 0xcfffffff]
> >
> > I use JTAG to confirm it.
> >
> > Thanks,
> > Peng.
> > >
> > > >  };
> > > >
> > > >  static const struct imx_rproc_att imx_rproc_att_imx8qm[] = {
> > > > --
> > > > 2.37.1
> > > >