RE: [PATCH 2/2] thermal/drivers/mellanox: Use generic thermal_zone_get_trip() function

[Vadim Pasternak]

> -----Original Message-----
> From: Vadim Pasternak
> Sent: Sunday, 30 October 2022 19:24
> To: Ido Schimmel <idosch@xxxxxxxxxx>; Daniel Lezcano
> <daniel.lezcano@xxxxxxxxxx>
> Cc: rafael@xxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Petr Machata <petrm@xxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; open
> list:MELLANOX ETHERNET SWITCH DRIVERS <netdev@xxxxxxxxxxxxxxx>
> Subject: RE: [PATCH 2/2] thermal/drivers/mellanox: Use generic
> thermal_zone_get_trip() function
> 
> 
> 
> > -----Original Message-----
> > From: Ido Schimmel <idosch@xxxxxxxxxx>
> > Sent: Tuesday, 25 October 2022 13:32
> > To: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>; Vadim Pasternak
> > <vadimp@xxxxxxxxxx>
> > Cc: Vadim Pasternak <vadimp@xxxxxxxxxx>; rafael@xxxxxxxxxx; linux-
> > pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Petr Machata
> > <petrm@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> > Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo
> > Abeni <pabeni@xxxxxxxxxx>; open list:MELLANOX ETHERNET SWITCH
> DRIVERS
> > <netdev@xxxxxxxxxxxxxxx>
> > Subject: Re: [PATCH 2/2] thermal/drivers/mellanox: Use generic
> > thermal_zone_get_trip() function
> >
> > On Tue, Oct 25, 2022 at 09:02:23AM +0200, Daniel Lezcano wrote:
> > > Because I hope I can remove the ops->get_trip_ ops from thermal_ops
> > > structure before the end of this cycle.
> >
> > OK. Vadim, any chance you can review the patch?
> 
> It seems to be OK.
> Anyway, I'll take this patch for testing by the end of this week and update.
> 

Hi guys,

I see this patch is already applied to Linux-next.
I tested it along with relevant patches from drivers/thermal and it looks OK.

Thanks,
Vadim.

> >
> > > May be you can consider moving the thermal driver into drivers/thermal?
> >
> > I don't think it's worth the hassle (if possible at all). In practice,
> > this code is upstream for almost six years and IIRC we didn't have any
> > conflicts with the thermal tree. I don't expect conflicts this cycle either.