Re: [PATCH] macintosh/adb: Fix warning comparing pointer to 0

[Christophe Leroy]

Le 06/11/2022 à 17:12, Christophe JAILLET a écrit :
> Le 06/11/2022 à 16:28, wangkailong@xxxxxxx a écrit :
>> Fix the following coccicheck warning:
>>
>> drivers/macintosh/adb.c:676:14-15: WARNING comparing pointer to 0.
>>
>> Signed-off-by: KaiLong Wang <wangkailong@xxxxxxx>

We already have such patches awaiting for application, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=83647

Please check patchwork before submitting such fixes as they may already 
exist.

Thanks
Christophe


>> ---
>>   drivers/macintosh/adb.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c
>> index 1bbb9ca08d40..076253599bd4 100644
>> --- a/drivers/macintosh/adb.c
>> +++ b/drivers/macintosh/adb.c
>> @@ -673,7 +673,7 @@ static int adb_open(struct inode *inode, struct 
>> file *file)
>>           goto out;
>>       }
>>       state = kmalloc(sizeof(struct adbdev_state), GFP_KERNEL);
>> -    if (state == 0) {
>> +    if (state) {
> 
> Hi
> no, this should be "if (!state)"
> 
> CJ
> 
>>           ret = -ENOMEM;
>>           goto out;
>>       }
>