Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188

[Krzysztof Kozlowski]

On 04/11/2022 08:44, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@xxxxxxxxxxxx>
> 
> add gce header file to define the gce thread priority, gce subsys id,
> event and constant for mt8188.
> 
> Signed-off-by: Elvis Wang <Elvis.Wang@xxxxxxxxxxxx>
> ---
> Thanks for the reviews, I have removed the incorrect reviewed message.
> ---
>  include/dt-bindings/gce/mediatek,mt8188-gce.h | 966 ++++++++++++++++++
>  1 file changed, 966 insertions(+)
>  create mode 100644 include/dt-bindings/gce/mediatek,mt8188-gce.h
> 
> diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h b/include/dt-bindings/gce/mediatek,mt8188-gce.h
> new file mode 100644
> index 000000000000..e2e2c56016a1
> --- /dev/null
> +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h


What is a "gce" subsystem or type of hardware? Why do you put headers in
"gce"?

Don't continue this pattern. Mediatek devices do not get specific folders...

Best regards,
Krzysztof