Re: [PATCH 2/2] dt-bingdings: mmc: Mediatek: add ICE clock

[Mengqi Zhang (张梦琦)]

On Wed, 2022-11-02 at 16:13 +0100, Ulf Hansson wrote:
> On Mon, 17 Oct 2022 at 16:20, Mengqi Zhang <mengqi.zhang@xxxxxxxxxxxx
> > wrote:
> > 
> > Document the binding for crypto clock of the Inline Crypto Engine
> > of Mediatek SoCs.
> > 
> > Signed-off-by: Mengqi Zhang <mengqi.zhang@xxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index d8e1e2e9adf2..f93d686e2911 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -57,6 +57,7 @@ properties:
> >        - description: peripheral bus clock gate (required for
> > MT8192).
> >        - description: AXI bus clock gate (required for MT8192).
> >        - description: AHB bus clock gate (required for MT8192).
> > +      - description: crypto clock used for data encrypt/decrypt
> > (optional).
> > 
> >    clock-names:
> >      minItems: 2
> > @@ -69,6 +70,7 @@ properties:
> >        - const: pclk_cg
> >        - const: axi_cg
> >        - const: ahb_cg
> > +      - const: crypto
> 
> Looks like minItems/maxItems for clocks needs to be updated too.
> 
> > 
> >    interrupts:
> >      description:
> > --
> > 2.25.1
> > 
> 
> Kind regards
> Uffe

Hi Uffe,

I just add crypto clock to mt8186/mt8188/mt8195, does not exceed the
minItems/maxItems.

I have re-sent my patch,

https://lore.kernel.org/linux-mmc/20221106033924.9854-3-mengqi.zhang@xxxxxxxxxxxx/
Please help to review it.
Thanks!

Regards,
Mengqi