Re: [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1

From: Brian Norris
Date: Sun Nov 06 2022 - 03:02:34 EST


On Tue, Oct 25, 2022 at 01:38:17AM +0200, Christian Marangi wrote:
> It was reported non working mmc with this option enabled.
> Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
> be run at 1.8v.
> Disable it to restore correct functionality of this SoC feature.
>
> Tested-by: Hendrik Koerner <koerhen@xxxxxx>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>

Perhaps there's some board where this property makes sense, but it seems
like something that should be added when needed in the leaf DTS, and not
supplied in the base DTSI. So:

Reviewed-by: Brian Norris <computersforpeace@xxxxxxxxx>

This also fixes problems I've seen on my systems, so:

Tested-by: Brian Norris <computersforpeace@xxxxxxxxx>

Thanks!