Re: [PATCH v1 1/1] platform/x86: p2sb: Don't fail if unknown CPU is found

From: Andy Shevchenko
Date: Fri Nov 04 2022 - 13:23:35 EST


On Fri, Nov 04, 2022 at 03:58:22PM +0000, Limonciello, Mario wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Sent: Friday, November 4, 2022 10:49

...

> > We have accessing P2SB from a very few places for quite known hardware.
> >
> > When a new SoC appears in intel-family.h it's not obvious that it needs
> > to be added to p2sb.c as well. Instead, provide default BDF and refactor
> > p2sb_get_devfn() to always succeed. If in the future we would need to
> > exclude something, we may add a list of unsupported IDs.
> >
> > Without this change the iTCO on Intel Commet Lake SoCs became
>
> Isn't it "Comet Lake"?

Right, thanks!

In any case I would like to have Jarkko's Tested-by before proceeding with
this. Hence v2 is warranted to appear.

> > unavailable:
> >
> > i801_smbus 0000:00:1f.4: failed to create iTCO device

--
With Best Regards,
Andy Shevchenko