Re: [PATCH] irqchip: loongson-liointc: fix improper error handling in liointc_init()

From: Liu Peibao
Date: Fri Nov 04 2022 - 06:59:30 EST


On 11/4/22 5:48 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 11/4/22 11:03 AM, Liu Peibao wrote:
>
>> For cores less than 4, eg, loongson2k1000 with 2 cores, the
>> of_property_match_string() may return with an error value,
>> which causes that liointc could not work. At least one isr
>> is what should be checked like previous commit <b2c4c3969fd7>
>> (irqchip/loongson-liointc: irqchip add 2.0 version) did.
>
> It should look like this:
>
> commit b2c4c3969fd7 ("irqchip/loongson-liointc: irqchip add 2.0 version")
>

Thanks, I will update the patch.

BR,
Peibao

>> Fixes: 0858ed035a85 ("irqchip/loongson-liointc: Add ACPI init support")
>> Signed-off-by: Liu Peibao <liupeibao@xxxxxxxxxxx>
> [...]
>
> MBR, Sergey
>