Re: [PATCH 2/4] iio: frequency: adf4377: add support for ADF4377

[Christophe JAILLET]

Le 04/11/2022 à 10:28, Antoniu Miclaus a écrit :
> The ADF4377 is a high performance, ultralow jitter, dual output integer-N
> phased locked loop (PLL) with integrated voltage controlled oscillator
> (VCO) ideally suited for data converter and mixed signal front end (MxFE)
> clock applications.
>
> Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adf4377.pdf
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus-OyLXuOCK7orQT0dZR+AlfA@xxxxxxxxxxxxxxxx>
> ---

[]

> +static int adf4377_properties_parse(struct adf4377_state *st)
> +{
> +	struct spi_device *spi = st->spi;
> +
> +	st->clkin = devm_clk_get(&spi->dev, "ref_in");

Hi,

this could be devm_clk_get_enabled() in order to...

> +	if (IS_ERR(st->clkin))
> +		return dev_err_probe(&spi->dev, PTR_ERR(st->clkin),
> +				     "failed to get the reference input clock\n");
> +
> +	st->gpio_ce = devm_gpiod_get_optional(&st->spi->dev, "ce-en",
> +					      GPIOD_OUT_HIGH);
> +	if (IS_ERR(st->gpio_ce))
> +		return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_ce),
> +				     "failed to get the CE GPIO\n");
> +
> +	st->gpio_enclk1 = devm_gpiod_get_optional(&st->spi->dev, "enclk1",
> +						  GPIOD_OUT_HIGH);
> +	if (IS_ERR(st->gpio_enclk1))
> +		return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk1),
> +				     "failed to get the CE GPIO\n");
> +
> +	if (st->type == ADF4377) {
> +		st->gpio_enclk2 = devm_gpiod_get_optional(&st->spi->dev, "enclk2",
> +							  GPIOD_OUT_HIGH);
> +		if (IS_ERR(st->gpio_enclk2))
> +			return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk2),
> +					     "failed to get the CE GPIO\n");
> +	}
> +
> +	return 0;
> +}
> +
> +static int adf4377_freq_change(struct notifier_block *nb, unsigned long action, void *data)
> +{
> +	struct adf4377_state *st = container_of(nb, struct adf4377_state, nb);
> +	int ret;
> +
> +	if (action == POST_RATE_CHANGE) {
> +		mutex_lock(&st->lock);
> +		ret = notifier_from_errno(adf4377_init(st));
> +		mutex_unlock(&st->lock);
> +		return ret;
> +	}
> +
> +	return NOTIFY_OK;
> +}
> +
> +static void adf4377_clk_disable(void *data)
> +{
> +	clk_disable_unprepare(data);
> +}

... remove this...

> +
> +static int adf4377_probe(struct spi_device *spi)
> +{
> +	struct iio_dev *indio_dev;
> +	struct regmap *regmap;
> +	struct adf4377_state *st;
> +	int ret;
> +
> +	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> +	if (!indio_dev)
> +		return -ENOMEM;
> +
> +	regmap = devm_regmap_init_spi(spi, &adf4377_regmap_config);
> +	if (IS_ERR(regmap))
> +		return PTR_ERR(regmap);
> +
> +	st = iio_priv(indio_dev);
> +
> +	indio_dev->info = &adf4377_info;
> +	indio_dev->name = "adf4377";
> +	indio_dev->channels = adf4377_channels;
> +	indio_dev->num_channels = ARRAY_SIZE(adf4377_channels);
> +
> +	st->regmap = regmap;
> +	st->spi = spi;
> +	st->type = spi_get_device_id(spi)->driver_data;
> +	mutex_init(&st->lock);
> +
> +	ret = adf4377_properties_parse(st);
> +	if (ret)
> +		return ret;
> +
> +	ret = clk_prepare_enable(st->clkin);
> +	if (ret)
> +		return ret;

... and this...

> +
> +	ret = devm_add_action_or_reset(&spi->dev, adf4377_clk_disable, st->clkin);
> +	if (ret)
> +		return ret;

... and this.

CJ

> +
> +	st->nb.notifier_call = adf4377_freq_change;
> +	ret = devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb);
> +	if (ret)
> +		return ret;
> +
> +	ret = adf4377_init(st);
> +	if (ret) {
> +		dev_err(&spi->dev, "adf4377 init failed\n");
> +		return ret;
> +	}
> +
> +	return devm_iio_device_register(&spi->dev, indio_dev);
> +}

[]