Re: [PATCH v2 4/5] blk-iocost: fix sleeping in atomic context warnning
From: Christoph Hellwig
Date: Fri Nov 04 2022 - 01:17:14 EST
On Fri, Nov 04, 2022 at 10:39:37AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> match_u64() is called inside ioc->lock, which causes smatch static
> checker warnings:
>
> block/blk-iocost.c:3211 ioc_qos_write() warn: sleeping in atomic context
> block/blk-iocost.c:3240 ioc_qos_write() warn: sleeping in atomic context
> block/blk-iocost.c:3407 ioc_cost_model_write() warn: sleeping in atomic
> context
>
> Fix the problem by introducing a mutex and using it while prasing input
> params.
s/prasing/parsing/
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>