Re: [PATCH] cpufreq: SPEAr: Make read-only array sys_clk_src static

From: Joe Perches
Date: Fri Nov 04 2022 - 00:51:55 EST


On Thu, 2022-11-03 at 14:36 +0000, Colin Ian King wrote:
> Don't populate the read-only array sys_clk_src on the stack but instead
> make it static and add in a missing const. Also makes the object code a
> little smaller.
[]
> diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
[]
> @@ -39,7 +39,7 @@ static struct clk *spear1340_cpu_get_possible_parent(unsigned long newfreq)
> * In SPEAr1340, cpu clk's parent sys clk can take input from
> * following sources
> */
> - const char *sys_clk_src[] = {
> + static const char * const sys_clk_src[] = {
> "sys_syn_clk",
> "pll1_clk",
> "pll2_clk",

sys_clk_src[2] isn't used and could be deleted with the
pclk indices changed.

Dunno what happened to the > 500000000 && != 600000000 range.