Re: [PATCH net-next v1.2] net: phy: fix yt8521 duplicated argument to & or |

From: Jakub Kicinski
Date: Fri Nov 04 2022 - 00:03:59 EST


On Thu, 3 Nov 2022 14:14:13 +0800 Frank wrote:
> cocci warnings: (new ones prefixed by >>)
> >> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or |
> drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or |
> drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or |
> drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or |
>
> The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx.
>
> Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Julia Lawall <julia.lawall@xxxxxxx>
> Signed-off-by: Frank <Frank.Sae@xxxxxxxxxxxxxx>

Please use your full legal name in the tag.

Please address the comments from the previous version, and read this:

https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr

Please use natural numbers for versioning - v1, v2, v3