Re: [PATCH] ASoC: Intel: cirrus-common: Make const array uid_strings static

[Pierre-Louis Bossart]

On 11/3/22 8:06 AM, Colin Ian King wrote:
> Don't populate the read-only const array uid_strings on the stack but
> instead make it static. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

> ---
>   sound/soc/intel/boards/sof_cirrus_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/sof_cirrus_common.c b/sound/soc/intel/boards/sof_cirrus_common.c
> index 6e39eda77385..851c516c8f5b 100644
> --- a/sound/soc/intel/boards/sof_cirrus_common.c
> +++ b/sound/soc/intel/boards/sof_cirrus_common.c
> @@ -155,7 +155,7 @@ static const char * const cs35l41_name_prefixes[] = { "WL", "WR", "TL", "TR" };
>    */
>   static int cs35l41_compute_codec_conf(void)
>   {
> -	const char * const uid_strings[] = { "0", "1", "2", "3" };
> +	static const char * const uid_strings[] = { "0", "1", "2", "3" };
>   	unsigned int uid, sz = 0;
>   	struct acpi_device *adev;
>   	struct device *physdev;