Re: [PATCHv4 2/9] zram: Add recompression algorithm sysfs knob

From: Minchan Kim
Date: Thu Nov 03 2022 - 13:12:26 EST


On Thu, Nov 03, 2022 at 01:09:49PM +0900, Sergey Senozhatsky wrote:
> On (22/11/03 12:05), Sergey Senozhatsky wrote:
> > What is the use case for removal of a secondary algorithm?
> >
> > > My point is that we don't need to implement it atm but makes the
> > > interface to open the possibility for future extension.
> > >
> > > What do you think?
> >
> > So, as far as I understand, we don't have reason to add remove_recomp_algo
> > right now. And existing recomp_algo does not enforce any particular format,
> > it can be extended. Right now we accept "$name" but can do something like
> > "$name:$priority".
>
> Or with keywords:
>
> name=STRING priority=INT
>
> and the only legal priority for now is 1.

I like it.