[PATCH] mm/slub: Add missing orig_size parameter for wastage debug
From: Feng Tang
Date: Thu Nov 03 2022 - 09:32:10 EST
commit 6edf2576a6cc ("mm/slub: enable debugging memory wasting of
kmalloc") was introduced for debugging kmalloc memory wastage,
and it missed to pass the original request size for kmalloc_trace()
and kmalloc_node_trace() in CONFIG_TRACING=n path.
Fix it by using __kmem_cache_alloc_node() with correct original
request size.
Fixes: 6edf2576a6cc ("mm/slub: enable debugging memory wasting of kmalloc")
Suggested-by: Vlastimil Babka <vbabka@xxxxxxx>
Signed-off-by: Feng Tang <feng.tang@xxxxxxxxx>
---
include/linux/slab.h | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/include/linux/slab.h b/include/linux/slab.h
index 90877fcde70b..9691afa569e1 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -469,6 +469,9 @@ void *__kmalloc_node(size_t size, gfp_t flags, int node) __assume_kmalloc_alignm
__alloc_size(1);
void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t flags, int node) __assume_slab_alignment
__malloc;
+void *__kmem_cache_alloc_node(struct kmem_cache *s, gfp_t flags, int node,
+ size_t orig_size, unsigned long caller) __assume_slab_alignment
+ __malloc;
#ifdef CONFIG_TRACING
void *kmalloc_trace(struct kmem_cache *s, gfp_t flags, size_t size)
@@ -482,7 +485,8 @@ void *kmalloc_node_trace(struct kmem_cache *s, gfp_t gfpflags,
static __always_inline __alloc_size(3)
void *kmalloc_trace(struct kmem_cache *s, gfp_t flags, size_t size)
{
- void *ret = kmem_cache_alloc(s, flags);
+ void *ret = __kmem_cache_alloc_node(s, flags, NUMA_NO_NODE,
+ size, _RET_IP_);
ret = kasan_kmalloc(s, ret, size, flags);
return ret;
@@ -492,7 +496,8 @@ static __always_inline __alloc_size(4)
void *kmalloc_node_trace(struct kmem_cache *s, gfp_t gfpflags,
int node, size_t size)
{
- void *ret = kmem_cache_alloc_node(s, gfpflags, node);
+ void *ret = __kmem_cache_alloc_node(s, gfpflags, node,
+ size, _RET_IP_);
ret = kasan_kmalloc(s, ret, size, gfpflags);
return ret;
--
2.34.1