Re: [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver.

From: Harald Mommer
Date: Thu Nov 03 2022 - 09:56:03 EST


Hello,

On 27.08.22 11:39, Marc Kleine-Budde wrote:
Is there an Open Source implementation of the host side of this
interface?
there is neither an open source device nor is it currently planned. The device I'm developing is closed source.
Please fix these checkpatch warnings:

| WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
| #65:
| new file mode 100644
|
Addressed most of the checkpatch warnings. Regarding the BUG_ON() minimized usage. Removed where not necessary, reworked where a better error handling was possible, kept where I don't think it will catch ever but if it catches I would like to know. Of course I could make the tool happy but on the other hand I don't want to fly completely blind in case a bug has to be hunted.
regards,
Marc

Regards
Harald