RE: [PATCH net v1] net: wwan: iosm: Remove unneeded if_mutex lock

From: Kumar, M Chetan
Date: Thu Nov 03 2022 - 09:35:11 EST


> -----Original Message-----
> From: zhaoping.shu@xxxxxxxxxxxx <zhaoping.shu@xxxxxxxxxxxx>
> Sent: Tuesday, November 1, 2022 11:21 AM
> To: Kumar, M Chetan <m.chetan.kumar@xxxxxxxxx>; linuxwwan
> <linuxwwan@xxxxxxxxx>; loic.poulain@xxxxxxxxxx; ryazanov.s.a@xxxxxxxxx;
> johannes@xxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; matthias.bgg@xxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; Liu, Haijun
> <haijun.liu@xxxxxxxxxxxx>; xiayu.zhang@xxxxxxxxxxxx;
> lambert.wang@xxxxxxxxxxxx; zhaoping.shu
> <zhaoping.shu@xxxxxxxxxxxx>
> Subject: [PATCH net v1] net: wwan: iosm: Remove unneeded if_mutex lock
>
> From: "zhaoping.shu" <zhaoping.shu@xxxxxxxxxxxx>
>
> These WWAN network interface operations (create/delete/open/close) are
> already protected by RTNL lock, i.e., wwan_ops.newlink(),
> wwan_ops.dellink(), net_device_ops.ndo_open() and net_device.ndo_stop()
> are called with RTNL lock held.
> Therefore, this patch removes the unnecessary if_mutex.
>
> Signed-off-by: zhaoping.shu <zhaoping.shu@xxxxxxxxxxxx>

Reviewed-by: M Chetan Kumar <m.chetan.kumar@xxxxxxxxx>