RE: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

From: Avri Altman
Date: Thu Nov 03 2022 - 03:05:05 EST


> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate device
> initialization") added check_upiu_size(), but no caller.
Nor there ever was.

>
> Cc: Dolev Raviv <draviv@xxxxxxxxxxxxxx>
> Signed-off-by: Keoseong Park <keosung.park@xxxxxxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxx>

> ---
> include/ufs/ufshcd.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index
> 96538eb3a6c0..5cf81dff60aa 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1072,12 +1072,6 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba,
> u32 id, u32 val); void ufshcd_hba_stop(struct ufs_hba *hba); void
> ufshcd_schedule_eh_work(struct ufs_hba *hba);
>
> -static inline void check_upiu_size(void) -{
> - BUILD_BUG_ON(ALIGNED_UPIU_SIZE <
> - GENERAL_UPIU_REQUEST_SIZE + QUERY_DESC_MAX_SIZE);
> -}
> -
> /**
> * ufshcd_set_variant - set variant specific data to the hba
> * @hba: per adapter instance
> --
> 2.17.1