Re: [PATCH 3/3] kunit: tool: remove redundant file.close() call in unit test

[David Gow]

On Thu, Nov 3, 2022 at 12:40 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote:
>
> We're using a `with` block above, so the file object is already closed.
>
> Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx>
> ---

Nice catch.

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David

>  tools/testing/kunit/kunit_tool_test.py | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py
> index 0063773c0fc4..c41567eaf3c3 100755
> --- a/tools/testing/kunit/kunit_tool_test.py
> +++ b/tools/testing/kunit/kunit_tool_test.py
> @@ -239,8 +239,6 @@ class KUnitParserTest(unittest.TestCase):
>                 self.assertEqual(
>                         "example",
>                         result.subtests[1].name)
> -               file.close()
> -
>
>         def test_ignores_prefix_printk_time(self):
>                 prefix_log = test_data_path('test_config_printk_time.log')
> --
> 2.38.1.273.g43a17bfeac-goog
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature