Re: [PATCH v2] io_uring: fix two assignments in if conditions

From: Jens Axboe
Date: Wed Nov 02 2022 - 10:19:37 EST


On 11/2/22 2:25 AM, korantwork@xxxxxxxxx wrote:
> From: Xinghui Li <korantli@xxxxxxxxxxx>
>
> Fixs two error:
>
> "ERROR: do not use assignment in if condition
> 130: FILE: io_uring/net.c:130:
> + if (!(issue_flags & IO_URING_F_UNLOCKED) &&
>
> ERROR: do not use assignment in if condition
> 599: FILE: io_uring/poll.c:599:
> + } else if (!(issue_flags & IO_URING_F_UNLOCKED) &&"
> reported by checkpatch.pl in net.c and poll.c .

I'm not super excited about this patch as the previous one
wasn't even compiled? Did you test this one, compile and runtime?

--
Jens Axboe