Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code

From: Adrian Hunter
Date: Wed Nov 02 2022 - 06:42:37 EST


On 1/11/22 12:52, Matthias Schiffer wrote:
> Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 8f1023480e12..4e17efa8ab97 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
>
> ret = mmc_of_parse(host->mmc);
> if (ret) {
> - dev_err(dev, "parsing dt failed (%d)\n", ret);
> + dev_err_probe(dev, ret, "parsing dt failed\n");
> goto pm_runtime_put;
> }
>