Re: [PATCH v6 13/21] gunyah: vm_mgr: Introduce basic VM Manager

From: Greg Kroah-Hartman
Date: Wed Nov 02 2022 - 01:14:12 EST


On Wed, Oct 26, 2022 at 11:58:38AM -0700, Elliot Berman wrote:
> +#define GH_CREATE_VM _IO(GH_IOCTL_TYPE, 0x40) /* Returns a Gunyah VM fd */

Why 0x40? Why not just use the same KVM ioctl numbers and names as you
are doing the same thing as them, right?

Normally your first ioctl is "0x01", not "0x40", so this feels really
odd.

thanks,

greg k-h