Re: [PATCH 1/1] smack_lsm: remove unnecessary type casting

From: Casey Schaufler
Date: Tue Nov 01 2022 - 17:13:11 EST


On 10/26/2022 1:29 AM, XU pengfei wrote:
> Remove unnecessary type casting.
> The type of inode variable is struct inode *, so no type casting required.
>
> Signed-off-by: XU pengfei <xupengfei@xxxxxxxxxxxx>

Thank you. Added to smack-next:
https://github.com/cschaufler/smack-next.git#next

> ---
> security/smack/smack_lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index b6306d71c908..853c6878edc0 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -1409,7 +1409,7 @@ static int smack_inode_getsecurity(struct user_namespace *mnt_userns,
> struct socket_smack *ssp;
> struct socket *sock;
> struct super_block *sbp;
> - struct inode *ip = (struct inode *)inode;
> + struct inode *ip = inode;
> struct smack_known *isp;
>
> if (strcmp(name, XATTR_SMACK_SUFFIX) == 0)