Re: [PATCH 2/4] blk-mq: improve error handling in blk_mq_alloc_rq_map()
From: Jens Axboe
Date: Tue Nov 01 2022 - 14:19:06 EST
On 11/1/22 11:34 AM, Christoph Hellwig wrote:
>> if (!tags)
>> - return NULL;
>> + goto err_out;
>
> Using a label just for the direct error return here is a bit silly.
Plus that's not idiomatic code for cleanup, just keep the NULL
return if there's no cleanup to be done.
--
Jens Axboe