Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in machine driver

[Mark Brown]

On Tue, Nov 01, 2022 at 03:15:08PM +0530, Venkata Prasad Potturu wrote:

> On 10/28/22 16:28, Mark Brown wrote:
> > > +static int tdm_mode = 0;
> > > +module_param_named(tdm_mode, tdm_mode, int, 0444);
> > > +MODULE_PARM_DESC(tdm_mode, "Set 1 for tdm mode, set 0 for i2s mode");
> > Why is this a module parameter - how would a user decide to set this?
> > Is it something that someone might want to change at runtime?
> 
> While inserting this module we need to pass tdm_mode variable as 0 or 1 like
> below.

> sudo insmod /lib/modules/$(uname
> -r)/kernel/sound/soc/amd/acp/snd-acp-mach.ko *tdm_mode=1*

Right, that's what the code does but why is this something that should
be controlled in this fashion?

Attachment: signature.asc
Description: PGP signature