Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)

From: Jason A. Donenfeld
Date: Tue Nov 01 2022 - 09:49:04 EST

Next message: Masami Hiramatsu (Google): "[PATCH v2 2/3] tools/perf: Fix to use dwarf_attr_integrate for generic attr accessor"
Previous message: Masami Hiramatsu (Google): "[PATCH v2 1/3] tools/perf: Fix to avoid crashing if DW_AT_decl_file is NULL"
In reply to: cuigaosheng: "Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)"
Next in thread: cuigaosheng: "Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Nov 1, 2022 at 2:37 PM cuigaosheng <cuigaosheng1@xxxxxxxxxx> wrote:
> > 215 [ 0.953146][ T0] UBSAN: shift-out-of-bounds in mm/shmem.c:3749:18
> > 216 [ 0.953863][ T0] left shift of 1 by 31 places cannot be represented in type 'int'

Isn't this just an issue with `1 << 31` needing to be `1U << 31`?

Jason

Next message: Masami Hiramatsu (Google): "[PATCH v2 2/3] tools/perf: Fix to use dwarf_attr_integrate for generic attr accessor"
Previous message: Masami Hiramatsu (Google): "[PATCH v2 1/3] tools/perf: Fix to avoid crashing if DW_AT_decl_file is NULL"
In reply to: cuigaosheng: "Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)"
Next in thread: cuigaosheng: "Re: [PATCH v2] x86/cpu: replacing the open-coded shift with BIT(x)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]